chore: consistently use direct imports for Lodash functions #3796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-kot
reviewed
Aug 26, 2025
| import Axe from 'axe-core'; | ||
| import { HtmlValidate } from 'html-validate'; | ||
| import { compact, uniq } from 'lodash'; | ||
| import compact from 'lodash/compact'; |
There was a problem hiding this comment.
Should we add an ESLint rule for pages to reinforce this?
pan-kot
approved these changes
Aug 26, 2025
This commit replaces barrel imports like
```
import { range } from 'lodash'
```
with direct imports like
```
import range from 'lodash/range'
```
All of these imports are in test code (Lodash is a devDependency only),
so this won't affect the build. But it will make code style more
consistent, and it should slightly improve test performance.
georgylobko
force-pushed
the
no-lodash-barrel
branch
from
4797589 to
b05c834
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3796 +/- ##
=======================================
Coverage 97.16% 97.17%
=======================================
Files 856 856
Lines 25229 25230 +1
Branches 8932 8933 +1
=======================================
+ Hits 24515 24516 +1
+ Misses 708 665 -43
- Partials 6 49 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
cloudscape-design:main
with commit Oct 24, 2025
59b27e4
47 of 48 checks passed
kuahuu
pushed a commit
to kuahuu/components
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces barrel imports like
with direct imports like
All of these imports are in test code (Lodash is a devDependency only), so this won't affect the build. But it will make code style more consistent, and it should slightly improve test performance.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.